Skip to content

Conversation

@WilliamJamieson
Copy link
Collaborator

I noticed that the pre-commit hooks where not really doing what I expected. It appears that for some reason #293 disabled them. Since JWST and Romancal both use all of these hooks I have re-enabled them here.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stcal@<branch>")
news fragment change types...
  • changes/<PR#>.apichange.rst: change to public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@WilliamJamieson
Copy link
Collaborator Author

We should consider using the pre-commit.ci bot instead of the tox style job. It provides some automatic fixing and auto updating of the pre-commit configuration. It is used by all the romancal related repos.

@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 91.72749% with 68 lines in your changes missing coverage. Please review.

Project coverage is 92.83%. Comparing base (3f7bd45) to head (2408d4c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/stcal/resample/resample.py 86.57% 20 Missing ⚠️
src/stcal/tweakreg/tweakreg.py 67.85% 9 Missing ⚠️
tests/test_tweakreg.py 80.48% 8 Missing ⚠️
src/stcal/skymatch/skymatch.py 89.83% 6 Missing ⚠️
src/stcal/skymatch/skyimage.py 68.75% 5 Missing ⚠️
src/stcal/saturation/saturation.py 84.00% 4 Missing ⚠️
src/stcal/tweakreg/astrometric_utils.py 72.72% 3 Missing ⚠️
src/stcal/jump/jump_class.py 71.42% 2 Missing ⚠️
src/stcal/jump/twopoint_difference.py 89.47% 2 Missing ⚠️
src/stcal/skymatch/skystatistics.py 87.50% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
+ Coverage   89.38%   92.83%   +3.44%     
==========================================
  Files          64       64              
  Lines       10213     9668     -545     
==========================================
- Hits         9129     8975     -154     
+ Misses       1084      693     -391     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WilliamJamieson WilliamJamieson marked this pull request as draft July 10, 2025 15:25
@pllim
Copy link
Contributor

pllim commented Oct 8, 2025

Would be nice to push this forward. I see unused imports and so on in the code and it triggers me. Why was this stalled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants