-
Notifications
You must be signed in to change notification settings - Fork 34
Update pre-commit hooks and sync ruff styling with JWST #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update pre-commit hooks and sync ruff styling with JWST #382
Conversation
|
We should consider using the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
==========================================
+ Coverage 89.38% 92.83% +3.44%
==========================================
Files 64 64
Lines 10213 9668 -545
==========================================
- Hits 9129 8975 -154
+ Misses 1084 693 -391 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Would be nice to push this forward. I see unused imports and so on in the code and it triggers me. Why was this stalled? |
I noticed that the pre-commit hooks where not really doing what I expected. It appears that for some reason #293 disabled them. Since JWST and Romancal both use all of these hooks I have re-enabled them here.
Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)"git+https://github.com/<fork>/stcal@<branch>")jwstregression testromancalregression testnews fragment change types...
changes/<PR#>.apichange.rst: change to public APIchanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.general.rst: infrastructure or miscellaneous change