TEST: Table dynamic units #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
added
the
no-changelog-entry-needed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #243 +/- ##
==========================================
+ Coverage 64.78% 64.82% +0.04%
==========================================
Files 103 103
Lines 5688 5695 +7
==========================================
+ Hits 3685 3692 +7
Misses 2003 2003 ☔ View full report in Codecov by Sentry. |
tapastro
reviewed
Dec 7, 2023
| type: string | ||
| fits_keyword: TUNIT9 | ||
| fits_hdu: EXTRACT1D |
There was a problem hiding this comment.
Needs an entry here for SB_VAR_RNOISE (and the increment of later TUNITS to fit). Will the default value (i.e. for the DQ column, which is unitless) be empty?
There was a problem hiding this comment.
Thanks for finding the mistake!
The default unit for all of these is None. If there are columns where units don't make sense (like DQ) we should consider either:
- setting the unit as
Nonein the schema (if this works) - leaving
DQout of thespec_table_unitsattribute
5 tasks
|
I'm closing this PR as it's out of date and hopefully served it purpose of demonstrating a way to have dynamic units in JWST. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test/example PR to explore/demonstrate dynamic units (with a path towards no FITS_rec usage in jwst) in the context of issue: #240
Based off changes in #242