Skip to content

Conversation

@rickgrubin-noaa
Copy link
Contributor

This PR adds versions for g2c and wgrib2 packages. For wgrib2, it also adds a new g2c-related variant, more clearly specifies versioning for the

These package are being used by the spack-stack partners and verified to work.

Notes:

For wgrib2, also adds:

  • new g2c-related variants and a corresponding conflicts() restraint
  • more clearly specifies versioning for the jasper and png variants
  • the dependency on ip is spelled out per README and CMakeLists.txt requirements detailed in tagged releases in the wgrib2 repository.

@rickgrubin-noaa
Copy link
Contributor Author

@spackbot fix style

@spackbot-app
Copy link

spackbot-app bot commented Jan 9, 2026

Let me see if I can fix that for you!

@spackbot-app
Copy link

spackbot-app bot commented Jan 9, 2026

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/aocc/package.py
repos/spack_repo/builtin/packages/g2c/package.py
repos/spack_repo/builtin/packages/hypre/package.py
repos/spack_repo/builtin/packages/openblas/package.py
repos/spack_repo/builtin/packages/orca/package.py
repos/spack_repo/builtin/packages/umpire/package.py
repos/spack_repo/builtin/packages/w3emc/package.py
repos/spack_repo/builtin/packages/wgrib2/package.py
�[1;34m==> �[0mrunning flake8
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
�[1;34m==> �[0mstyle checks passed
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

But it looks like I'm not able to push to your branch. 😭️ Did you check Allow edits from maintainers when you opened the PR?

@climbfuji
Copy link
Contributor

@AlexanderRichert-NOAA Unfortunately, you need to approve once more after the formatting updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants