Skip to content

Conversation

@rbberger
Copy link
Member

Fixes oversight of #2721

@rbberger
Copy link
Member Author

Ignore all the messages before. I had an old branch updates/kokkos which became the target branch automatically when I created the PR. The moment I fixed it, everyone was marked as reviewer.

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cedricchevalier19 @lucbv @nmm0 @tpadioleau Any objections to this PR being merged?

@tldahlgren tldahlgren self-assigned this Jan 12, 2026
@tldahlgren tldahlgren added the waiting-on-maintainer Waiting on a review from the package maintainer label Jan 12, 2026
@tldahlgren tldahlgren enabled auto-merge (squash) January 12, 2026 18:09
@tldahlgren tldahlgren removed the waiting-on-maintainer Waiting on a review from the package maintainer label Jan 12, 2026
Copy link
Contributor

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@tldahlgren tldahlgren disabled auto-merge January 12, 2026 20:54
@tldahlgren tldahlgren enabled auto-merge (squash) January 12, 2026 20:55
@tldahlgren
Copy link
Contributor

tldahlgren commented Jan 12, 2026

Unclear why there are no links or other information for the seemingly stuck All or ci checks and the Checks tab says 0 checks.

Going to try Update branch.

@tldahlgren tldahlgren merged commit 3eff4a1 into spack:develop Jan 12, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants