Add options: query_only? and resource_fun
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By specifying the `query_only?` option to true, only parent query spans are sent, and child spans are omitted. This makes trace data size ~1/4.
|
For example, with these 2 options, we can make statistics of most accessed tables/access types from spans like this: |
…a query Instead of adding `telemetry_options` to every query, this allows to provide a custom function to convert a query to span's resource. It is useful to group queries by target table names, for example.
sekiyama58
force-pushed
the
resource-converter-fun
branch
from
8415b3c
to
9d574a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds 2 options:
query_only?query_only?: true, only parentqueryspans are sent, and childqueue/run_query/decodespans are omitted.This makes trace data size ~1/4.
resource_funtelemetry_optionsto every query, this allows to provide a custom function to convert a query to span's resource.It is useful to group queries by target table names, for example.