Skip to content

Deprecate custom version comparators#2639

Merged
zorgiepoo merged 4 commits into2.xfrom
deprecate-custom-comparators
Oct 7, 2024
Merged

Deprecate custom version comparators#2639
zorgiepoo merged 4 commits into2.xfrom
deprecate-custom-comparators

Conversation

@zorgiepoo
Copy link
Copy Markdown
Member

Fixes #2585

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

@zorgiepoo zorgiepoo added this to the 2.7 milestone Sep 30, 2024
@github-actions
Copy link
Copy Markdown

/Users/runner/work/Sparkle/Sparkle/Sparkle/SUUpdater.m:463:1: warning: implementing deprecated method [-Wdeprecated-implementations] - (id<SUVersionComparison>)versionComparatorForUpdater:(SPUUpdater *)__unused updater ^ In file included from /Users/runner/work/Sparkle/Sparkle/Sparkle/SUUpdater.m:15: /Users/runner/work/Sparkle/Sparkle/Sparkle/SPUUpdaterDelegate.h:389:1: note: method 'versionComparatorForUpdater:' declared here - (nullable id<SUVersionComparison>)versionComparatorForUpdater:(SPUUpdater *)updater __deprecated_msg("Custom version comparators are deprecated because they are incompatible with how the system compares different versions of an app."); ^ 1 warning generated. /Users/runner/work/Sparkle/Sparkle/Sparkle/SUUpdater.m:463:1: warning: implementing deprecated method [-Wdeprecated-implementations] - (id<SUVersionComparison>)versionComparatorForUpdater:(SPUUpdater *)__unused updater ^ In file included from /Users/runner/work/Sparkle/Sparkle/Sparkle/SUUpdater.m:15: /Users/runner/work/Sparkle/Sparkle/Sparkle/SPUUpdaterDelegate.h:389:1: note: method 'versionComparatorForUpdater:' declared here - (nullable id<SUVersionComparison>)versionComparatorForUpdater:(SPUUpdater *)updater __deprecated_msg("Custom version comparators are deprecated because they are incompatible with how the system compares different versions of an app."); ^ 1 warning generated. note: Run script build phase 'Strip Framework' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle') note: Run script build phase 'Run Script: Set Git Version Info' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle') note: Run script build phase 'Run Script: Link Tools' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle')

@zorgiepoo zorgiepoo merged commit 544c642 into 2.x Oct 7, 2024
@zorgiepoo zorgiepoo deleted the deprecate-custom-comparators branch October 7, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate custom version comparators

1 participant