Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: avoid gumbo_debug function calls when GUMBO_DEBUG isn't def'd #2723

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Dec 11, 2022

What problem is this PR intended to solve?

Part of #2722, optimizing performance of gumbo.

Benchmarks from running show 7-11% improvements.

  • "test/files/GH_1042.html", # 650b
  • "test/files/tlm.html", # 70kb
  • "big_shopping.html", # 1.9mb
Comparison:
nodbg html5 parse 656:    16646.6 i/s
BASE_ html5 parse 656:    15545.9 i/s - same-ish: difference falls within error
                   with 99.0% confidence

Comparison:
nodbg html5 parse 70095:      271.1 i/s
BASE_ html5 parse 70095:      253.1 i/s - same-ish: difference falls within error
                   with 99.0% confidence

Comparison:
nodbg html5 parse 1929522:       14.9 i/s
BASE_ html5 parse 1929522:       13.4 i/s - 1.11x  (± 0.07) slower
                   with 99.0% confidence

@flavorjones flavorjones merged commit 60230b6 into main Dec 20, 2022
@flavorjones flavorjones deleted the flavorjones-gumbo-benchmarking branch December 20, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant