Autotools gumbo #3221
Open
Autotools gumbo #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement a minimal autotools build for libgumbo. - Make `rake gumbo:test` use the same libgumbo.a used to build the nokogiri extension. - Make changes to `gumbo-parser/src` trigger a rebuild of libgumbo.
flavorjones
force-pushed
the
autotools-gumbo
branch
3 times, most recently
from
81c8a76
to
845d7cb
Compare
- remove the `rebuild-libgumbo` target which is probably not needed once #3220 is merged - avoid downloading googletest when just running `rake compile` - update the Manifest check to ignore new gumbo-parser/ files - simplify the 'host' variable in gumbo.rake, since we're only using it in development (and not cross-compiling) - put back the libgumbo $libs, $LIBPATH, and include flags modifications - make sure libgumbo is built static
flavorjones
force-pushed
the
autotools-gumbo
branch
3 times, most recently
from
33b3156
to
c47b232
Compare
|
I'm a little concerned about introducing autoconf to the development build process; I made some additional changes to help run it better in CI, but I think we probably also need to add a test job that installs the gem on a system without autoconf just to make sure we're packaging everything correctly. |
flavorjones
force-pushed
the
autotools-gumbo
branch
from
c47b232
to
f36ee54
Compare
and make sure autoconf is installed in the basic ubuntu container in CI
flavorjones
force-pushed
the
autotools-gumbo
branch
from
f36ee54
to
6e6b368
Compare
|
@stevecheckoway I wonder if we should split gumbo out into a separate repository? While it might make integration testing a little bit harder,
Just an idle thought on a Saturday morning. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
See conversation at #2718, this simplifies how we build libgumbo both during installation (extconf) and during development.
Primary author is @stevecheckoway
Have you included adequate test coverage?
Existing test coverage should be fine.
Does this change affect the behavior of either the C or the Java implementations?
No behavior changes.