make SQLite3::Database.open return the block result instead of the db instance #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
requested changes
Oct 22, 2023
… instance
To make it follow common pattern, like for File:
result = File.open('/dev/zero') do |f|
f.read(10)
end
See discussion in sparklemotion#414
toy
force-pushed
the
open-return-block-result
branch
from
adee4c7
to
0ef9a94
Compare
flavorjones
approved these changes
Oct 27, 2023
|
Interface tells me that I can merge, ok to do so? |
|
Thanks for your patience, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it follow common pattern, like for File:
See discussion in #414