Implement GVL-releasing, backing-off busy_timeout #475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After getting a tad more experienced with the C portion of this codebase, I decided to try and see if I could implement the logic of SQLite's
busy_timeout
(with its backoff logic) in the extension such that we could release the GVL while sleeping. You can find SQLite's implementation ofsqlite3_busy_timeout
here and the default callback functionality here.I think this is a good start, but I am stumped because when I try to compile, I get this error:
I'm not certain why this method isn't available, but how can I sleep and release the GVL here in C-land? Any help on this would be greatly appreciated. (note: I see from CI that this method is only missing in
darwin
environments. Interesting)cc @suwyn who originally challenged me to do this in C-land.