Enhance ldl API #203
Merged
Enhance ldl API #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in the documentation of transform_mat_papt, the same process works whether the input matrix is CSC or CSR. This is a breaking change, but this API is kept unstable as it is very prone and its use case is quite specific to `sprs-ldl` for now. We now enforce this more by hiding this function from the docs.
This API uses the builder pattern and will try and use good defaults, such as picking an appropriate fill-in reducing permutation (Reverse Cuthill-McKee for now as that's all that is implemented).
The rationale is that other crates might depend on this info.
This way it becomes easy to compare the rust version and the C version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a more ergonomic API to the LDL factorization algorithm, which makes it easy to compute a factorization yet allows customization of some options, such as disabling symmetry check or choosing a method to get a good fill-in reducing permutation.
This should help investigate #199.