Skip to content

Commit

Permalink
Remove the // from leak detection output so it will cause test failur…
Browse files Browse the repository at this point in the history
…es now.

TypedTemplatedLiterals.via is the last remaining leak in the Vireo test
suite, but it is in a feature not currently generated by DFIR and only used internally
(and this usage does not cause the leak.)  Modify the test to avoid the
leak, but with a TO-DO to address it in the future.  (Git issue ni#378)
  • Loading branch information
spathiwa committed Mar 12, 2018
1 parent 87ff4c6 commit 9e7108a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion source/core/TypeAndDataManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ void TypeManager::PrintMemoryStat(ConstCStr message, Boolean bLast)
if (bLast && (_totalAllocations == 1) && (_totalAQAllocated == sizeof(TypeManager))) {
// If bLast is true then silence is success.
} else {
gPlatform.IO.Printf("//Allocations %4d, AQCount %5zd, ShareTypes %d (%s)\n", (int)_totalAllocations, _totalAQAllocated, _typesShared, message);
gPlatform.IO.Printf("LEAKS: Allocations %4d, AQCount %5zd, ShareTypes %d (%s)\n", (int)_totalAllocations, _totalAQAllocated, _typesShared, message);
}
#endif
}
Expand Down
2 changes: 1 addition & 1 deletion test-it/ViaTests/TypedTemplatedLiterals.via
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ start( dv(VirtualInstrument (
Println(TestPointGeneric)
Println(TestPointInt8)
Println(TestPointInt32)
Println(TestPointComplexDouble)
Println(TestPointComplexDouble<()>) // !!! without the <()> arg, this leaks! TODO(spathiwa) investigate

Println(TestPointInt8_2_3)
Println(TestPointInt8<(2 3)>)
Expand Down

0 comments on commit 9e7108a

Please sign in to comment.