Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions for custom mapping only work for non-tbl data #13

Open
angela-li opened this issue Oct 23, 2019 · 3 comments
Open

Functions for custom mapping only work for non-tbl data #13

angela-li opened this issue Oct 23, 2019 · 3 comments
Labels
check This should already be fixed, double check that it is

Comments

@angela-li
Copy link
Member

angela-li commented Oct 23, 2019

Custom boxbreaks functions and such in Basic Mapping - Extreme Value Maps were written for st_read( )-output spatial data and doesn't play well with read_sf( )-output spatial data (aka tibbles)

Need to revise functions to work with tibbles and/or get them into tmap as PRs.

@angela-li
Copy link
Member Author

Workaround for now so that book still builds, is to remove tbl class from nyc_sf from geodaData (0b42a19): not a permanent solution, need to fix functions.

@angela-li
Copy link
Member Author

I think the problem is that the first 3 tutorials use read_sf and the 4th one uses st_read, which leads to inconsistency in terms of data reading. Need to settle on one way to read in spatial data!

@angela-li
Copy link
Member Author

Chatted with Grant, I think we'll try to stick with st_read( ) for rest of functions - can always convert others to tbls later. Will affect geodaData datasets (make sf objects, but not tibbles, except for nyc data? or just do as_tibble())

@angela-li angela-li added the check This should already be fixed, double check that it is label Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check This should already be fixed, double check that it is
Projects
None yet
Development

No branches or pull requests

1 participant