Added support for holidays in Nigeria #10
Conversation
src/Countries/Nigeria.php
Outdated
| return array_merge([ | ||
| 'New Year\'s Day' => "01-01", | ||
| 'Worker\'s Day' => "05-01", | ||
| 'Children\'s Day' => "05-27", |
There was a problem hiding this comment.
Is this an official public holiday? I don't find it here: https://publicholidays.africa/nigeria/2024-dates/
There was a problem hiding this comment.
I guess it's not regarded as an official holiday, i'll remove it @Nielsvanpach
There was a problem hiding this comment.
There also seem to be official Muslim holidays on the list. I'm not aware of the rules in Nigeria on this? Is this a public holiday for everyone in the whole country?
There was a problem hiding this comment.
The muslim holidays are for everyone but the exact calculation of these holidays involves the sighting of the moon, and it can vary depending on different interpretations within the Islamic community. @Nielsvanpach
|
Could you add armed forces remembrance day? |
I don't think the armed forces Remembrance Day is regarded as a public holiday in Nigeria, as much as it is celebrated, everybody still get to go about their day's work |
|
Hmm that's interesting Thanks for the clarification |
|
What about labour day? |
It's same as workers day |
|
I'm sorry I missed that Great job |
|
Could you rebase this branch, so the tests will run? |
…eature/nigeria-holidays
|
just did that @Nielsvanpach |
|
I'll leave this PR open until we have a proper solution for Islamic holidays. |
|
Thanks! |
Changes Introduced:
Introduction of a new Nigeria class to handle accurate calculations for Nigeria public holidays.
Overview:
This pull request introduces a dedicated Nigeria class within the Spatie\Holidays\Countries namespace. The class is designed to handle precise calculations for public holidays in Nigeria. This addition ensures that developers have access to accurate dates for both fixed and variable holidays specific to Nigeria.
Correlation Check:
Reviewers can confirm the correlation of the generated holidays by comparing them with the official holidays listed on here.