Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Bahrain holidays #108

Closed
wants to merge 0 commits into from
Closed

Added Bahrain holidays #108

wants to merge 0 commits into from

Conversation

bo3bdo
Copy link
Contributor

@bo3bdo bo3bdo commented Jan 18, 2024

Added Bahrain holidays.

habibalkhabbaz
habibalkhabbaz suggested changes Jan 19, 2024
View reviewed changes
Copy link

@habibalkhabbaz habibalkhabbaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on some lines, because some of holidays will be only correct for this year 2024 but not for next years.

src/Countries/Bahrain.php Outdated Show resolved Hide resolved
@bo3bdo
Copy link
Contributor Author

bo3bdo commented Jan 24, 2024

update phpstan test

Nielsvanpach
Nielsvanpach reviewed Jan 25, 2024
View reviewed changes
src/Countries/Bahrain.php Outdated Show resolved Hide resolved
lang/bahrain/ar/bahrain.json Outdated Show resolved Hide resolved
src/Countries/Bahrain.php Outdated Show resolved Hide resolved
@bo3bdo bo3bdo closed this Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssmusoke ssmusoke ssmusoke left review comments

@Nielsvanpach Nielsvanpach Nielsvanpach left review comments

@habibalkhabbaz habibalkhabbaz Awaiting requested review from habibalkhabbaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bo3bdo @ssmusoke @Nielsvanpach @habibalkhabbaz