Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pakistan Holidays #127

Closed
wants to merge 2 commits into from
Closed

Added Pakistan Holidays #127

wants to merge 2 commits into from

Conversation

hammadzafar05
Copy link

@hammadzafar05 hammadzafar05 commented Jan 19, 2024

Source: Public Holidays In Pakistan - Wikipedia
(https://en.wikipedia.org/wiki/Public_holidays_in_Pakistan)

@NabeelYousafPasha
Copy link

Respected @hammadzafar05

My PR for PAKISTAN is already opened 16+ hours ago, #99 is the PR.

My checks were executed, I'm fixing PHPStan analysis.
Kindly close your PR so we don't have conflicts. Thank You

"Have you checked to ensure there aren't other open [Pull Requests](https://github.com/spatie/holidays/pulls) for the same country?"

@hammadzafar05
Copy link
Author

Respected @hammadzafar05

My PR for PAKISTAN is already opened 16+ hours ago, #99 is the PR.

My checks were executed, I'm fixing PHPStan analysis. Kindly close your PR so we don't have conflicts. Thank You

"Have you checked to ensure there aren't other open [Pull Requests](https://github.com/spatie/holidays/pulls) for the same country?"

Ok Dear,
I'm closing my PR.
Good Luck!

@NabeelYousafPasha
Copy link

Thanks for your cooperation @hammadzafar05 .
Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants