Support for Bulgarian holidays #132
Conversation
src/Countries/Bulgaria.php
Outdated
| * @return CarbonImmutable | ||
| * @throws \RuntimeException if the calculated date is invalid | ||
| */ | ||
| protected function calculateEasterDate($year): CarbonImmutable |
There was a problem hiding this comment.
Is this an orthodox calculation? We already have one in Country.php. Does that one work too?
There was a problem hiding this comment.
I totally didn't see that. Yes it works for Bulgaria too.
There was a problem hiding this comment.
I think you used the wrong one.
There was a problem hiding this comment.
Yep you're right.. Its correct for 2024 5 May 2024, but for 2025 it should be 20 April 2025. I'm not sure which calculation to use..
There was a problem hiding this comment.
Ok using the easter_date function directly actually resolves the issue.
There was a problem hiding this comment.
Ok, nevermind.. 🤣 It's now wrong for 2024, im confused..
There was a problem hiding this comment.
Country.php has a easter() and orthodoxEaster() function. I suggest to use one of those.
If the orthodox calculation gives a false result, feel free to update it, in order to make it work. Do verify if the results for NorthMacedonia is still correct.
There was a problem hiding this comment.
Neither functions give proper result, i will investigate more.
There was a problem hiding this comment.
The problem is that this function in Country.php is wrong calculating the OrthodoxEastern. Please check Greece #114 to fix the problem. @Nielsvanpach needs to update orthodoxEaster()
Country.php has a easter() and orthodoxEaster() function.
There was a problem hiding this comment.
It's still the wrong function you're calling. You should use orthodoxEaster()
| @@ -0,0 +1,46 @@ | |||
| [ | |||
| { | |||
| "name": "\u041d\u043e\u0432\u0430 \u0433\u043e\u0434\u0438\u043d\u0430", | |||
There was a problem hiding this comment.
If needed, you ca also add a translation file to the lang directory
Co-authored-by: Niels Vanpachtenbeke <[email protected]>
Co-authored-by: Niels Vanpachtenbeke <[email protected]>
|
Could you have a look at the failing test? |
|
Dear contributor, because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it. |
Contributing a new country ?