Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Colombian holidays #141

Closed
wants to merge 1 commit into from
Closed

Add Colombian holidays #141

wants to merge 1 commit into from

Conversation

luisprmat
Copy link

Contributing a new country ?

  • Have you checked to ensure there aren't other open Pull Requests for the same country?

Yes, i have checked and I know PR#55 exists for the same country, but it has problems with phpstan. I have rewritten the function that generated problems with types and now the phpstan analysis passes.

PR#55 can be closed in favour of this.

  1. Create a new class in the Countries directory. It should extend the Country class.
  2. Add a test for the new country in the tests directory.
  3. Run the tests so a snapshot gets created.
  4. Verify the result in the newly created snapshot is correct.

@Nielsvanpach
Copy link
Member

Could you help #55 with fixing it instead? Thanks!

@luisprmat luisprmat closed this Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants