Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for country regions #39

Closed
wants to merge 2 commits into from
Closed

add support for country regions #39

wants to merge 2 commits into from

Conversation

Nielsvanpach
Copy link
Member

No description provided.

@Nielsvanpach Nielsvanpach changed the title add support for regions for countries add support for country regions Jan 17, 2024
@marlonbasten
Copy link

Also a good solution! Can you maybe also look at my solution? #37
I think both solutions have certain upsides and downsides. Yours is simple and easier to extend.
Mine is more type-safe when needed and adds the functionality to get only state-specific holidays

@patrickomeara patrickomeara mentioned this pull request Jan 18, 2024
Merged
@Nielsvanpach Nielsvanpach deleted the feature/regions branch January 19, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nielsvanpach @marlonbasten