Improve validation performance - add cache (PoC - needs feedback) #1044
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the additional PoC for adding a simple cache for static rules as extended logic to PR #1043
Please share feedback as it's potentially a bit "hardcoded" with a list of unsafe rules to cache, maybe there is some better approach.
But the positive thing is that using the same benchmark as in PR #1043 it saves additionally 20% (around 200ms in time instead of about 258ms.