make download name optional

spatie · Mar 4, 2024 · b263e83 · b263e83
1 parent 592e9ea
commit b263e83
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/src/PdfBuilder.php b/src/PdfBuilder.php
@@ -137,15 +137,13 @@ public function footerHtml(string $html): self
 
     public function download(?string $downloadName = null): self
     {
-        $this->name($downloadName);
+        $this->name($downloadName ?? 'download');
 
         $this->addHeaders([
             'Content-Type' => 'application/pdf',
             'Content-Disposition' => 'attachment; filename="'.$this->downloadName.'"',
         ]);
 
-        $this->name($downloadName);
-
         return $this;
     }
 

diff --git a/tests/PdfReponseTest.php b/tests/PdfReponseTest.php
@@ -7,13 +7,20 @@
         ->assertHeader('content-disposition', 'inline; filename="my-custom-name.pdf"');
 });
 
-it('can download the pdf', function () {
+it('can download the pdf with a name', function () {
     $this
         ->get('download-pdf')
         ->assertHeader('content-type', 'application/pdf')
         ->assertHeader('content-disposition', 'attachment; filename="my-custom-name.pdf"');
 });
 
+it('can download the pdf without a name', function () {
+    $this
+        ->get('download-nameless-pdf')
+        ->assertHeader('content-type', 'application/pdf')
+        ->assertHeader('content-disposition', 'attachment; filename="download.pdf"');
+});
+
 it('will tack on pdf to the filename if it is missing', function (string $method) {
     $headerMethod = $method === 'inline' ? 'inline' : 'attachment';
 

diff --git a/workbench/routes/web.php b/workbench/routes/web.php
@@ -19,3 +19,7 @@
 Route::get('download-pdf', function () {
     return pdf('test')->download('my-custom-name.pdf');
 });
+
+Route::get('download-nameless-pdf', function () {
+    return pdf('test')->download();
+});