Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StateFusion misses read-write conflict due to early return #1954

Open
wants to merge 3 commits into
base: v1/maintenance
Choose a base branch
from

Conversation

FlorianDeconinck
Copy link
Contributor

@FlorianDeconinck FlorianDeconinck commented Feb 26, 2025

Check for all potential match in _check_paths to not miss potential memlets_intersect failure.

Unit tests for checks the internal _check_paths function since it triggers on a non deterministic networkx search.

⚠️ This code exists as-is in main as of Feb 26 and showcase the same issue, cherry-picking fix will have to happen ⚠️

@tbennun
Copy link
Collaborator

tbennun commented Feb 26, 2025

This looks reasonable, makes sense. I would add a test though with the SDFG API and a certain node addition ordering for sanity’s sake.

@FlorianDeconinck
Copy link
Contributor Author

Unit tests in. Instead of figuring out a test that would pass most check but the one we are fixing, I am testing that one check (_check_paths). The bug is subtle and depends on what networkx respond on a leaf search, which doesn't seem to be deterministic...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants