-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JAX Support to NPBench and Implement JAX Benchmarks #31
Open
hardik01shah
wants to merge
113
commits into
spcl:main
Choose a base branch
from
hardik01shah:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define the JaxFramework class for implementing block_until_ready() calls after kernel computation for correctness of profiling, convert np.ndarray to jax Array in the copy_func()
Define the JaxFramework class for implementing block_until_ready() calls after kernel computation for correctness of profiling, convert np.ndarray to jax Array in the copy_func()
Add lib implementation to jax
Previously >10x slower, now around same runtime as numpy.
Previously was up to 70x slower, now it's faster for smaller sizes and comparable to numpy for bigger ones.
Previously was up to 90x slower, now it's up to 40x faster than numpy.
Previously was up to 3x slower, now comparable to numpy.
Add JAX as a supported framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR introduces JAX as a supported framework in NPBench, providing JAX implementations for all existing benchmarks. This enhancement allows NPBench to compare the performance of JAX against other frameworks, for all implemented benchmarks in NPBench.
Changes Introduced:
framework_info/jax.json
to define framework-specific configuration settings for JAX.npbench/benchmarks/<bench_parent>/<bench_name>_jax.py
.npbench/benchmarks/<bench_parent>/<bench_name>_jax_lib.py
npbench/infrastructure/__init__.py
to include JAX framework initialization.npbench/infrastructure/jax_framework.py
to handle:block_until_ready()
andjnp.array()
).jax_framework.py
related to incorrect naming of the current framework during benchmarking.Motivation:
The addition of JAX support enhances NPBench by:
Testing and Validation:
Contributors: