-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Libfabric refactor with curiously recurring template pattern #37
Draft
mattnappo
wants to merge
94
commits into
master
Choose a base branch
from
libfabric-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move `libfabric-refactor-traits` into `libfabric-refactor`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch provides a refactor of the original libfabric implementation. The code here branched off of libfabric-sarus.
This PR removes the
#ifdef USE_LIBFABRIC
flags in almost all places. We use the curiously recurring template pattern (CRTP) to switch between the verbs and libfabric implementations during template instantiation at compile time. See my final report here for more details.Note that the current state of this branch is broken. The linker is failing:
We might need to link both ibverbs and libfabric in order to build the binary, which is not desirable. There might be a way around this, though.
rfaaslib
andrdmalib
do successfully link and compile. However, since the executor does not currently link, I was unable to execute or run end-to-end tests of rFaaS on the CSCS machines, which is why I am opening this PR as a draft.While refactoring, I did not change any program semantics. There are no architecture changes or optimizations. This was merely a source code transformation, and does not change how rFaaS actually works. I just swapped the conditional compilation pattern from using
#ifdef
s to using CRTP, which is much more sustainable in the long term.See #36 for some initial code review and requested changes. Hopefully we'll get this code up and running soon!