Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schemas to disallow lists in paragraphs #1762

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

goneall
Copy link
Member

@goneall goneall commented Dec 26, 2022

Fixes #1758

Signed-off-by: Gary O'Neall [email protected]

@goneall
Copy link
Member Author

goneall commented Dec 26, 2022

This PR seems to be working - the CI is failing with the following expected errors:

  - src/CECILL-1.1.xml: Unexpected child with tag 'tns:list' at position 2.
  - src/CDL-1.0.xml: Unexpected child with tag 'tns:list' at position 1.
  - src/libpng-2.0.xml: Unexpected child with tag 'tns:list' at position 1.
  - src/APL-1.0.xml: Unexpected child with tag 'tns:list' at position 1.
  - src/Caldera.xml: Unexpected child with tag 'tns:list' at position 1.
  - src/OPUBL-1.0.xml: Unexpected child with tag 'tns:list' at position 1.

@zvr - If you could review the schema changes. I don't know if there is a more elegant way to structure the schema file to avoid all the duplicate code - but the changes seem to work based on some manual testing and the CI results.

@goneall goneall requested a review from zvr December 26, 2022 23:19
@goneall
Copy link
Member Author

goneall commented Dec 26, 2022

@swinslow - FYI - WIP on an updated schema for issue #1758 related to issue #1680

Once this is reviewed, we can update the above license XML files that are failing validation.

@swinslow
Copy link
Member

Great, thank you @goneall! I'm happy to go through and update the broken XML files after you give me the go-ahead.

@jlovejoy
Copy link
Member

@swinslow @goneall - what are we doing with this one?

@swinslow swinslow added this to the 3.21 milestone Feb 15, 2023
@BethNash2029

This comment was marked as spam.

@swinslow swinslow modified the milestones: 3.21, 3.22 Jun 18, 2023
@swinslow swinslow modified the milestones: 3.22, Later Release Sep 30, 2023
@jlovejoy jlovejoy requested a review from swinslow May 9, 2024 17:55
@xsuchy
Copy link
Collaborator

xsuchy commented Oct 23, 2024

I propose that right after next release (planned at 31 Oct), we merge this. And then fix anything that gets broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Schema to disallow lists inside of paragraphs
5 participants