feat(Badge): update styles for badge #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chase-crumbaugh
approved these changes
Sep 25, 2025
farazcsk
approved these changes
Sep 26, 2025
There was a problem hiding this comment.
LGTM!
Just a couple tweaks you can accept
If you are feeling particularly moonshiny today https://www.figma.com/design/01eoIoRHuBAfqGiyUT4ZpV/Moonshine---Speakeasy-Design-system?node-id=3181-10555&m=dev
- We are removing the "default" variant and replacing it with "neutral" which will be the default, but not by name.
- There is a "withBackground" variant which looks tasty.
Co-authored-by: Faraz Khan <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
I'd be happy to take a crack at those other improvements. I think I'll do in a separate PR though just cause I got a lot of moving parts in the air and I think I gotta scope down and get the stuff I have released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made a somewhat reckless change as a foray into moonshine. Screenshot of updated badges below that are a pretty large departure from existing badges and introduce a
text-transformper the request of @farazcsk . I would love it if the rules were to just recklessly release such things but I have a suspicion I might be on the hook for updating some downstream consumers.Before
After