-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect if first login #6262
base: production
Are you sure you want to change the base?
Detect if first login #6262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code suggests that there may be multiple institution
records in a single database, both in what is displayed to the user and in the API endpoint. Currently, I'm not aware of any plans to support more than one institution per database, but perhaps this decision was made with the understanding that this may not always be the case.
Is this intentional, or should it return only one institution at any given time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
35fb53e
to
0f25eee
Compare
@grantfitzsimmons, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine functionally. However, I think we should reconsider the route we're creating, especially after 0f25eee (sorry!)
Fixes #6211
Checklist
self-explanatory (or properly documented)
Testing instructions