fix(revit): Missing Type Mark parameter added #1112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1112 +/- ##
=======================================
Coverage 41.56% 41.56%
=======================================
Files 110 110
Lines 3164 3164
Branches 306 306
=======================================
Hits 1315 1315
Misses 1806 1806
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjoernsteinhagen
approved these changes
Sep 26, 2025
bimgeek
deleted the
bilal/cnx-2395-revit-370-type-mark-parameter-is-missing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Type Mark parameter was being filtered out during parameter extraction because Autodesk internally names it WINDOW_TYPE_ID, which gets caught by the EndsWith("_ID") filter that was designed to exclude less meaningful ID parameters.
Related to: https://linear.app/speckle/issue/CNX-2395/revit-370-type-mark-parameter-is-missing
Community report: https://speckle.community/t/type-mark-revit-parameter-missing-when-publishing-to-speckle/20380?u=nikos
Modified the parameter filtering logic in ParameterExtractor.cs to specifically allow WINDOW_TYPE_ID while maintaining the existing behavior for other ID parameters: