Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUI3 289 investigate and create versioning poc #3547

Draft
wants to merge 6 commits into
base: dui3/alpha
Choose a base branch
from

Conversation

BovineOx
Copy link
Contributor

This is related to the PR draft here: specklesystems/speckle-sharp-sdk#7

The first step with object upgrading had to be the (unexpected) act of excising Kits from the SDK. Most of Kits has now gone, what remains appears to be largely unrelated to kits.

Type Caching is now done with a new ITypeCache, an AbstractTypeCache and and ObjectsTypeCache. In theory, because this is injected down to Receive, it is possible to continue doing a kits like thing, by passing in a different TypeCache. By default the ObjectsTypeCache is caching all types that are derived from Base and found in the assembly where ObjectsTypeCache exists and the base, i.e. looking in Core and Objects. This might be something we can do a bit more elegantly but it's definitely no worse than existing.

Note that some changes may relate to working with the SDK and the connectors at the same time.

@BovineOx
Copy link
Contributor Author

I'd like to discuss the wisdom of checking the lock files in - I believe they are auto-generated and it's adding some unnecessary noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant