Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev -> Main #3682

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Dev -> Main #3682

wants to merge 26 commits into from

Conversation

JR-Morgan
Copy link
Member

DO NOT SQUASH!

JR-Morgan and others added 26 commits August 8, 2024 12:48
…elected object. (#3651)

* Correct access for const

* Corrected NullParam exception signature

* LINQ logic made logical

* corrected correction

* indent all the things
… duplicate (#3652)

* Correct access for const

* Corrected NullParam exception signature

* LINQ logic made logical

* corrected correction

* indent all the things

* First becomes Last
* Updated DUI2

* remove comment subscription

* Comments

* fix comment

* VersionUpdate subscription workaround

* Dynamo

* Fixed issue with collections being modified while enumerating

* removed deprecated tests

* Marked deprecated true on all legacy subscriptions

* using directives
Remove keyboard shortcuts from plugin registration
For POC purposes - implements a fix - needs investigation
* Ensure CI runs on net8

* remove net 7

* bump csharpier for net8 support

* ensure net8 sdk is available on connector builds

* relax rollforward rules instead
* File Added: ConvertStructuralMaterial

Separated methods pertaining to StructuralMaterial outside of the ConvertAnalyticalStick.cs file. Didn't make sense that these functions were in the ConvertAnalyticalStick.cs when the ConvertAnalyticalSurface.cs referenced them

* ScaleToSpeckle

Material properties were sent as revit internal units. Inconsistent with the Revit model / project units. These can't be used for connection applications (e.g. receiving analytical elements in ETABS)

* ETABS Receive Property2D

ETABS currently only created properties for Element2Ds with a CSIProperty2D, but what about Property2D? These should also be received without us defaulting to the "Slab1" ETABS section.

* ETABS Receive Wall Property

Walls were previously assigned with slab sections which is incorrect. The WallPropertyToNative() was implemented (previously raised a ConversionNotSupportedException for some reason)

* RVT 22 Scaling Updates

Testing on Revit 2022 - ETABS connection

* Default Fallback

Assign at least something to Element2D

* Fixed shared project case sensitivity

* IDE0005

---------

Co-authored-by: Jedd Morgan <[email protected]>
* ping should ping a static asset and add user agent headers

* fix: fmt

* Removed frontend headers check for FE1 servers

* Removed another test that relied on this pinging

---------

Co-authored-by: Dimitrie Stefanescu <[email protected]>
Co-authored-by: Jedd Morgan <[email protected]>
Removed tracking for grasshopper node runs
* Multi-ping

* tests

* adjusted timeouts
* Optimised large queries

* fix mistake
* Optimised large queries

* fix mistake

* fix another mistake
* fix: Dissapearing components after save

SyncReceive would disappear upon opening a document (or while saving) due to exceptions being thrown in the Read/Write logic, which shouldn't ever throw.

* fix: Write method for Kit name is unnecessary, dealt with in parent class
Do not assume internal storage `m_value` will exist in all GH_Goo's, some have varying implementation, but `Value` is usually consistent on all pre-rhino8 GH types
@clairekuang clairekuang self-requested a review January 23, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants