This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
Feature/sidenav fix #186
Open
Feature/sidenav fix #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KapRom
commented
May 7, 2018
KapRom
commented
- Fixed the horizontal scroll of sidenav
- Fixed the squeezing of main content on mobile version
- On desktop the sidenav is as before - open by default
- On mobile the sidenav is hidden by default, opened is over the main content:
Sebaxp95
reviewed
May 7, 2018
src/app/app.component.ts
Outdated
| isMobile() { | ||
| const innerWidth = window.innerWidth || document.documentElement.clientWidth || document.body.clientWidth; | ||
|
|
||
| if (innerWidth < this.minimalPixels) { |
There was a problem hiding this comment.
simplify: return innerWidth < this.minimalPixels;
gmrukwa
approved these changes
Jun 16, 2018
|
I've just seen this review, after almost 2 months hanging... :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.