-
Notifications
You must be signed in to change notification settings - Fork 1
Create complete Apostrophe CMS Docker environment #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
killev
commented
Apr 13, 2025
- Create Docker Compose with MongoDB, Redis, and Mongo Express
- Add development environment with hot-reload support
- Implement secure Dockerfile with non-root user
- Configure persistent storage for database and cache
- Add health checks for all services
- Include comprehensive documentation
- Create Docker Compose with MongoDB, Redis, and Mongo Express - Add development environment with hot-reload support - Implement secure Dockerfile with non-root user - Configure persistent storage for database and cache - Add health checks for all services - Include comprehensive documentation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (3)
- Dockerfile: Language not supported
- website/package-lock.json: Language not supported
- website/package.json: Language not supported
Comments suppressed due to low confidence (2)
docker-compose.yml:23
- The Apostrophe service healthcheck uses wget. Ensure that wget is installed in the image or consider an alternative command (e.g., using curl) to avoid potential failures in environments where wget is not available.
test: ["CMD", "wget", "--no-verbose", "--tries=1", "--spider", "http://localhost:3000/"]
docker-compose.yml:40
- The MongoDB healthcheck command may misinterpret the nested quotes. Consider escaping the inner double quotes properly (e.g. using "ping") to ensure the command executes reliably.
test: echo 'db.runCommand("ping").ok' | mongosh localhost:27017/test --quiet