Skip to content

[717] The vertical alignment of the photos with the grey separators is slightly off #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
killev merged 4 commits into from
Jul 4, 2025
Merged

[717] The vertical alignment of the photos with the grey separators is slightly off #204

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e05d05
fix: adjusted styles to avoid layout shift and border behavior on hover
yuramax Jul 4, 2025
5a3ba3c
Merge branch 'main' into 717-the-vertical-alignment-of-the-photos-wit…
yuramax Jul 4, 2025
f1d3d34
Merge branch 'main' into 717-the-vertical-alignment-of-the-photos-wit…
killev Jul 4, 2025
b76faa4
Merge branch 'main' into 717-the-vertical-alignment-of-the-photos-wit…
killev Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 50 additions & 47 deletions website/modules/asset/ui/src/scss/_leadership-team.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,20 @@
// prevent extra top border when leader-card is hovered in second row
& + .leadership-list {
.leader-card {
&:hover {
@include breakpoint-large {
border-top: none;

.leader-header {
.leader-title-block {
@include breakpoint-large {
border-top: 1px solid transparent;
}
margin-bottom: 1px;
}
}

&:hover {
@include breakpoint-large {
border-top: none;

.leader-header {
margin-bottom: 1px;
}
}
}
Expand All @@ -40,47 +48,15 @@
height: 100%;
margin-bottom: 24px;
position: relative;
border-top: 1px solid transparent;
border-left: 1px solid $whisper;
border-bottom: 1px solid $whisper;

@include breakpoint-large {
max-height: 383px;
max-width: 400px;
margin-bottom: 0;
}

// avoid double border
&:not(:first-child) {
.leader-header {
.leader-title-block {
@include breakpoint-large {
border-left: none;
}
}
}

.leader-footer {
@include breakpoint-large {
border-left: none;
}
}
}

// avoid double border on hover for leader-card
&:has(+ .leader-card:hover) {
.leader-header {
.leader-title-block {
@include breakpoint-large {
border-right: none;
}
}
}

.leader-footer {
@include breakpoint-large {
border-right: none;
}
}
}

.leader-header {
display: flex;
max-width: calc(100% - 102px);
Expand All @@ -91,25 +67,45 @@
}

.leader-title-block {
padding: 29px 24px;
padding: 27px 24px;
width: 100%;
box-sizing: border-box;

@include breakpoint-large {
padding: 40px 40px 0;
border: 1px solid $whisper;
border-bottom: none;
border: none;
border-top: 1px solid $whisper;
width: auto;
}
}
}

.leader-footer {
padding: 24px;
border: 1px solid $whisper;
border-top: 1px solid $whisper;
border-right: 1px solid $whisper;

@include breakpoint-large {
padding: 0 40px 40px;
border-top: none;
border-right: none;
padding: 0 40px 40px;
}
}

&:last-child {
@include breakpoint-large {
.leader-header {
.leader-title-block {
border-right: 1px solid $whisper;
}
}
.leader-footer {
border-right: 1px solid $whisper;
}

&:hover {
border-right: 1px solid $whisper;
}
}
}

Expand Down Expand Up @@ -182,6 +178,12 @@
}

&:hover {
border-top: 1px solid transparent;

@include breakpoint-large {
border-top: 1px solid $whisper;
}

.leader-photo {
@include breakpoint-large {
opacity: 0;
Expand Down Expand Up @@ -219,14 +221,15 @@
.leader-header {
.leader-title-block {
@include breakpoint-large {
border-left: 1px solid $whisper;
border: none;
margin-bottom: 1px;
}
}
}

.leader-footer {
@include breakpoint-large {
border-left: 1px solid $whisper;
border: none;
}
}
}
Expand Down
Loading