Skip to content

Add ACL private #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a-nomad merged 5 commits into from
Mar 31, 2026
Merged

Add ACL private #265

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
acf6e8b
acl private
a-nomad Mar 25, 2026
f66727f
fix(uploadfs): set S3 bucketObjectsACL to private by default
Mar 25, 2026
8a81f82
fix lint error
Mar 25, 2026
915012c
fix: avoid ACL settings by default for S3 uploads
Mar 26, 2026
096e5a3
Merge branch 'main' into feature/acl
IhorMasechko Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion website/modules/@apostrophecms/uploadfs/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ const uploadfsOptions = {
storage: 's3',
bucket: getEnv('APOS_S3_BUCKET'),
region: getEnv('APOS_S3_REGION'),
acl: process.env.APOS_S3_ACL || null,
cdn: {
enabled: true,
url: getEnv('APOS_CDN_URL'),
Expand All @@ -33,6 +32,11 @@ if (aposS3Secret) {
uploadfsOptions.key = getEnv('APOS_S3_KEY');
}

const aposS3BucketObjectsAcl =
process.env.APOS_S3_ACL || 'private';
Comment thread
IhorMasechko marked this conversation as resolved.
Outdated
uploadfsOptions.bucketObjectsACL = aposS3BucketObjectsAcl;
uploadfsOptions.disabledBucketObjectsACL = aposS3BucketObjectsAcl;

const res = {
options: {
uploadfs: uploadfsOptions,
Expand Down
Loading