Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spegel Grafana dashboard with Spegel-specific metrics #612

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AhmedTremo
Copy link
Contributor

@AhmedTremo AhmedTremo commented Oct 17, 2024

Why updated Grafana dashboard?

  • The old dashboard included general Kubernetes metrics such as node statuses, running containers, pods, Kubelet operations, which was making it hard to follow Spegel-specific metrics.
  • The old dashboard wasn't function properly and didn't include time-series panels to monitor change over time.

By concentrating on Spegel-specific metrics, users can more effectively monitor and troubleshoot Spegel without clutter from other Kubernetes metrics (I think they should have their own dashboard).

This is a view of the new dashboard in action. Let me know your thoughts

1-correct
2
3

@phillebaba
Copy link
Member

Thanks for the contribution @AhmedTremo.

@onedr0p just wanted to check to see if you have any opinions about these changes.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 16 files with indirect coverage changes

@onedr0p
Copy link
Contributor

onedr0p commented Oct 18, 2024

@AhmedTremo

I don't see spegel_mirror_requests_total or spegel_resolve_duration_seconds_bucket being exported by spegel. This might be on my end, but I do have some spegel metrics being ingested so not sure where those are.

I also don't have any data graphed in the http_request_duration_seconds_bucket or http_response_size_bytes_bucket panels.

@AhmedTremo
Copy link
Contributor Author

AhmedTremo commented Oct 18, 2024

@onedr0p

I re-checked pkg/metrics/metrics.go and these metrics are implemented and should be exportable, are you sure Prometheus is correctly configured?

The images I shared were for Spegel running v0.0.23 but I don't think there were any metrics changes since then, (correct me if I'm wrong @phillebaba)

@onedr0p
Copy link
Contributor

onedr0p commented Oct 18, 2024

As I said it's probably on my end, but I do have other spegel metrics being ingested by prometheus so I'm stumped as to why those two are missing.

@AhmedTremo
Copy link
Contributor Author

Yes, I think it's worth investigating. one thing to mention is I set 30-second window for calculating rate which might be shorter than scraping interval for some folks, and I do it for the metrics you mentioned

spegel_mirror_requests_total
spegel_resolve_duration_seconds_bucket
http_request_duration_seconds_bucket
http_response_size_bytes_bucket

So, I will update it to 5m just to be safe. Can you check if updating the window shows the metrics for you? @onedr0p

@onedr0p
Copy link
Contributor

onedr0p commented Oct 18, 2024

Now I am getting data in the http_request_duration_seconds_bucket and http_response_size_bytes_bucket panels. Still no dice for the other two.

@AhmedTremo
Copy link
Contributor Author

AhmedTremo commented Oct 18, 2024

I think we would need someone else to try it and validate to be sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants