-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Spegel Grafana dashboard with Spegel-specific metrics #612
base: main
Are you sure you want to change the base?
Conversation
Thanks for the contribution @AhmedTremo. @onedr0p just wanted to check to see if you have any opinions about these changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
I don't see I also don't have any data graphed in the |
I re-checked pkg/metrics/metrics.go and these metrics are implemented and should be exportable, are you sure Prometheus is correctly configured? The images I shared were for Spegel running v0.0.23 but I don't think there were any metrics changes since then, (correct me if I'm wrong @phillebaba) |
As I said it's probably on my end, but I do have other spegel metrics being ingested by prometheus so I'm stumped as to why those two are missing. |
Yes, I think it's worth investigating. one thing to mention is I set 30-second window for calculating rate which might be shorter than scraping interval for some folks, and I do it for the metrics you mentioned
So, I will update it to 5m just to be safe. Can you check if updating the window shows the metrics for you? @onedr0p |
Now I am getting data in the |
I think we would need someone else to try it and validate to be sure |
Why updated Grafana dashboard?
By concentrating on Spegel-specific metrics, users can more effectively monitor and troubleshoot Spegel without clutter from other Kubernetes metrics (I think they should have their own dashboard).
This is a view of the new dashboard in action. Let me know your thoughts