Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent getCompletions from modifying os.Args #2258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonathan-conder
Copy link

@jonathan-conder jonathan-conder commented Mar 12, 2025

Possible fix for #2257.

Tested using this test case:

func TestModifiedArgs(t *testing.T) {
	cmd := &Command{TraverseChildren: true}
	args := []string{"__complete", ""}
	cmd.SetArgs(args)
	if err := cmd.Execute(); err != nil {
		t.Errorf("Unexpected error: %v", err)
	}
	if len(args) != 2 || args[1] != "" {
		t.Error("Modified args")
	}
}

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants