Assorted small fixups #380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 1cd6182 added this check, but the len built-in never returns negative values. Change the check to len() == 0. Fixes: 1cd6182 Signed-off-by: Kir Kolyshkin <[email protected]>
This mostly fixes some code snippets in godoc strings. Signed-off-by: Kir Kolyshkin <[email protected]>
This fixes some whitespace issues, and in general improves code formatting. Signed-off-by: Kir Kolyshkin <[email protected]>
All these places have two problems: 1. Using fprintf with no %-like format specifiers. 2. Missing newline. Fix both by switching to fprintln. Signed-off-by: Kir Kolyshkin <[email protected]>
|
|
Before this commit, go test fails like this: ./flag_test.go:1241:3: fmt.Println arg list ends with redundant newline FAIL github.com/spf13/pflag [build failed] Signed-off-by: Kir Kolyshkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing dramatic; please see individual commits for details.