FEAT: Initial migration to the present 🏃 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daquintero
commented
Jan 11, 2024
•
daquintero
commented
- Update to pyproject.toml
- Update to current python versions
- Update .gitignore
- Readme.rst to Readme.md (easy to rebase this out if we don't want)
- Github action to replace tox testing
- Add precommit
|
Example here https://github.com/daquintero/sphinxcontrib-autoflex |
stephenfin
requested changes
Jan 16, 2024
| "Operating System :: OS Independent", | ||
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.6", |
There was a problem hiding this comment.
These don't match the CI configuration. Could you update?
| follow_imports = "skip" | ||
| incremental = true | ||
| check_untyped_defs = true | ||
| warn_unused_ignores = true |
There was a problem hiding this comment.
I'd drop this. I suspect mypy is rarely used in most sphinx extensions.
|
|
||
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.6" |
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.6" | ||
| pbr = "^5.5.1" |
There was a problem hiding this comment.
tbh, pbr probably isn't the best horse to back now. Could we use setuptools here?
Later actually you us poetry so this should be wholly unnecessary?
| - id: isort | ||
|
|
||
| - repo: https://github.com/asottile/black | ||
| rev: 22.3.0 # Use the latest version of black |
There was a problem hiding this comment.
This isn't the latest (none of these are). Could you bump?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.