fix(Turntable): Disc not turning and not showing next and previous songs #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disc not turning, nor next and previous songs showing at bottom:
After fix it is working as inteded:
One fix was concerning Spicetify buttons, which don't necessarily have a title when creating them with
Spicetify.Topbar.Button, but rather can use Tippy. Thus, fadBtn must also be looked for by the contents of Tippy.Another fix made sure that the action performed when clicking fadBtn had effect after the "Full App Display" was loaded.