-
Notifications
You must be signed in to change notification settings - Fork 21
Enhancements: Example Config File, Default Path, and Error Handling Improvements #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements: Example Config File, Default Path, and Error Handling Improvements #199
Conversation
I can't tell from a quick skim of the patch, where its going to try to read the default config file from in a containerized environment. Where is it going to look? |
In a containerized environment, the code will attempt to read the default config file from |
19e9113
to
1c22ad6
Compare
It would be better I think if the user didn't have to read a Dockerfile to try and find where that is? Defaulting to something more well defined like /etc/java-spiffe-helper.conf would help make it more concrete out of the box? |
The
|
If you want to do that for non containers, then I think the command suggestion in #187 is still the right thing to do for the containerized side then. |
conf/java-spiffe-helper.conf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this file have extension .properties
rather than .conf
? Java properties files typically have the .properties
suffix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
1c22ad6
to
e366d0d
Compare
This PR add improvements to the
java-spiffe-helper
:--config
Parameter.