Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): update repo name #2

Merged
merged 2 commits into from
Feb 2, 2024
Merged

chore(*): update repo name #2

merged 2 commits into from
Feb 2, 2024

Conversation

vdice
Copy link
Contributor

@vdice vdice commented Feb 2, 2024

Update the repo name

(Note: none of the referenced sample or k3d images actually exist yet, pending CI/CD.)

May rely on #1 cc @Mossaka

Signed-off-by: Vaughn Dice <[email protected]>
@vdice vdice mentioned this pull request Feb 2, 2024
1 task
@Mossaka
Copy link
Member

Mossaka commented Feb 2, 2024

Is there a way to move the issues from one repo to another?

@vdice
Copy link
Contributor Author

vdice commented Feb 2, 2024

Is there a way to move the issues from one repo to another?

Are you thinking between deislabs/containerd-wasm-shims and this repo? It isn't possible since they are different organizations... so we'd have to re-create.

@vdice
Copy link
Contributor Author

vdice commented Feb 2, 2024

@Mossaka I added more naming updates in e1ee0d9 which included changes in the GH workflows that I think I got right, but could use a close look.

Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleaning up

@Mossaka Mossaka merged commit b29f93f into main Feb 2, 2024
1 of 8 checks passed
@vdice vdice deleted the chore/update-repo-name branch February 2, 2024 20:07
calebschoepp added a commit to calebschoepp/containerd-shim-spin that referenced this pull request Apr 2, 2024
This attempts to integrate spin-telemetry by turning off the logger in containerd-shim. Note this means that the containerd-shim-spin logs end up getting picked up by the Spin app b/c it has a tracing subscriber with the tracing-log feature turned on.

Signed-off-by: Caleb Schoepp <[email protected]>
rylev pushed a commit to rylev/containerd-shim-spin that referenced this pull request Jun 14, 2024
Move to new test-environment crate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants