fix(shutdown): handle termination for container #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radu-matei
changed the title
|
@radu-matei does this close/resolve the referenced issues? |
This commit handles incoming termination signal for tasks, ensuring tasks are correctly terminated. Signed-off-by: Radu Matei <[email protected]> Co-authored-by: Rajat Jindal <[email protected]>
kate-goldenring
force-pushed
the
fix/shutdown
branch
from
bf26bdb to
77b383b
Compare
kate-goldenring
approved these changes
Mar 5, 2024
endocrimes
approved these changes
Mar 5, 2024
|
@kate-goldenring this is part of resolving #22 (the other part being in Spin). |
Mossaka
approved these changes
Mar 6, 2024
| log::error!("ERROR >>> Trigger executor failed: {:?}", err); | ||
| Err(err) | ||
| } | ||
| Err(aborted) => { |
There was a problem hiding this comment.
In what situations will the spin engine abort?
There was a problem hiding this comment.
Hi @Mossaka,
My understanding (based on running tests with a k3d based setup) is that when a pod is terminating, it will send the TERM signal to the shim. and because we were not handling the term signal, this will continue to run until a KILL signal is sent after TerminateGracefulSeconds limit is crossed.
Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit handles incoming termination signal for tasks, ensuring
tasks are correctly terminated.
diff for this change: bf26bdb
ref #22
ref spinkube/spin-operator#40
ref deislabs/containerd-wasm-shims#207
Signed-off-by: Radu Matei [email protected]
Co-authored-by: Rajat Jindal [email protected]