Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pull in termination patch from runwasi #47

Merged

Conversation

kate-goldenring
Copy link
Collaborator

  • also sets default log level of "error" now that we can configure a lower level than "info". This can be overwritten by setting RUST_LOG level for containerd process.
    fixes Pods stuck in terminating state #39

Copy link
Contributor

@jsturtevant jsturtevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kate-goldenring
Copy link
Collaborator Author

Holding to pull in containerd/runwasi#521

- also updates the shim Config to have "error" default log level

Signed-off-by: Kate Goldenring <[email protected]>
@kate-goldenring kate-goldenring merged commit bebbea7 into spinkube:main Mar 19, 2024
9 checks passed
@kate-goldenring kate-goldenring deleted the runwasi-with-cgroups-patch branch March 19, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pods stuck in terminating state
3 participants