adds basic setup for e2e testing #115
Conversation
michelleN
commented
Feb 29, 2024
michelleN
commented
- adds a simple e2e test for the containerd executor
|
This PR now has an image available for testing: |
michelleN
force-pushed
the
e2e
branch
2 times, most recently
from
c74aeee
to
9d82c22
Compare
There was a problem hiding this comment.
Thanks Michelle, this is some great work. The actual code itself LGTM but I have a number of overarching questions:
- How do these e2e tests compare to the tests we have like
spinapp_controller_test.go. It's clear to me the setup is at a different level of abstraction, but what will this allow us to test that the other can't? - How do these e2e tests compare to the smoke tests we have? Does this obviate the need for some of our smoke tests?
- Would it be possible to add these tests into the CI in this PR? It'd be nice to be able to see they're passing.
e2e/default_test.go
Outdated
| // TestDefaultSetup is a test that checks that the minimal setup works | ||
| // | ||
| // with the containerd wasm shim runtime as the default runtime. |
There was a problem hiding this comment.
Nit: Formatting for this comment
e2e/k3d_provider.go
Outdated
| } | ||
|
|
||
| func (c *Cluster) Destroy() error { | ||
|
|
There was a problem hiding this comment.
I'm gonna give this a proper review tomorrow but generally LGTM - I don't love the bdd-i-ness, but it's at least go-test-y bdd.
@calebschoepp this is gonna be great for testing things like #122 - where we want to be able to validate that the provided runtime config is something that the shim can understand - because that relies on having a real cluster, rather than just an API serverr.
| jobs: | ||
| e2e: | ||
| runs-on: ubuntu-latest | ||
| steps: |
There was a problem hiding this comment.
needs the standard boilerplate of checkout steps / installing Go
+ adds a simple e2e test for the containerd executor Signed-off-by: Michelle Dhanani <[email protected]>
|
+ adds e2e make target for running e2es + updates return err to include output for better debugging experience + add workflow for checking e2e on PRs to main Signed-off-by: Michelle Dhanani <[email protected]>
