test(e2e): add ability to skip building docker image #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreese
requested review from
calebschoepp,
endocrimes,
bacongobbler and
michelleN
as code owners
|
What's the intention behind setting |
|
Yep, when I'm writing e2e tests I comment out that line because it takes a long time to build when there's no need for it |
calebschoepp
approved these changes
Jun 26, 2024
endocrimes
reviewed
Jun 26, 2024
e2e/main_test.go
Outdated
| if p := utils.RunCommand(`bash -c "cd .. && IMG=ghcr.io/spinkube/spin-operator:dev make docker-build"`); p.Err() != nil { | ||
|
|
||
| return ctx, fmt.Errorf(ErrFormat, p.Err(), p.Out()) | ||
| if os.Getenv("E2E_SKIP_BUILD") == "" { |
There was a problem hiding this comment.
gonna need to update the linter config to allow this in e2e/
This allows you to run e2e tests without rebuilding the image by setting E2E_SKIP_BUILD environment variable. Signed-off-by: Adam Reese <[email protected]>
adamreese
force-pushed
the
test/skip-build
branch
from
e84a2c4
to
c1a82ba
Compare
endocrimes
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to run e2e tests without rebuilding the image by setting E2E_SKIP_BUILD environment variable.