Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): add vault-provider.yaml showing generic loadFromSecret approach #275

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vdice
Copy link
Contributor

@vdice vdice commented Jul 15, 2024

I wanted to add the loadFromSecret generic runtime config approach to a sample somewhere for improved visibility.

Not sure if this is the best approach. Could also create a new sample to put this in. Thoughts?

@endocrimes
Copy link
Contributor

A new sample would be preferred - because it can also show how to use it.

That being said - I'm not sure if we're going to keep this long term? - it was kinda an escape hatch during early development that I think we've outlived the usefulness of.

@calebschoepp
Copy link
Contributor

I'm in support of removing LoadFromSecret support.

@vdice vdice force-pushed the samples/runtime-config-load-from-secret branch from ddbd246 to faca441 Compare July 16, 2024 15:47
@vdice
Copy link
Contributor Author

vdice commented Jul 16, 2024

I'm in support of removing LoadFromSecret support.

The loadFromSecret functionality is currently useful for providing Vault and/or Azure Key Vault application variable provider config to SpinApps, since there is no typed support in the Spin Operator, yet. Perhaps consider removing after #272 lands -- assuming it represents the last bit of typed runtime config to be added for parity with Spin?

Also note the integration between loadFromSecret and the kube plugin.

@vdice
Copy link
Contributor Author

vdice commented Jul 16, 2024

As for this example, happy to close if indeed we'd like not to advertise this functionality. I just found it useful for my use case.

If we'd like to keep this sample manifest, I can also add a corresponding sample app to apps if that would be preferred.

@vdice vdice changed the title docs(samples): add loadFromSecret config to runtime-config.yaml docs(samples): add vault-provider.yaml showing generic loadFromSecret approach Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants