deployment: Set SPIN_HTTP_LISTEN_ADDR env var #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently a "practical no-op", as we default to setting the value to the Spin Default. It does however simplify a future, bigger, change to allow non-80 listen addresses with the container to reduce the priviliges that we give to the shim (e.g runAsNonRoot).
endocrimes
requested review from
calebschoepp,
bacongobbler and
michelleN
as code owners
rajatjindal
reviewed
Aug 15, 2024
| @@ -423,7 +423,7 @@ func constructDeployment(ctx context.Context, app *spinv1alpha1.SpinApp, config | |||
| Requests: app.Spec.Resources.Requests, | |||
| } | |||
|
|
|||
| env := ConstructEnvForApp(ctx, app) | |||
| env := ConstructEnvForApp(ctx, app, spinapp.DefaultHTTPPort) | |||
There was a problem hiding this comment.
so in future we may add the ability to override the port using SpinApp CRD?
There was a problem hiding this comment.
I think we'll want to keep it "automatic", but it'll at least be able to be non-80 😅
rajatjindal
approved these changes
Aug 15, 2024
rajatjindal
reviewed
Aug 15, 2024
| return nil | ||
| } | ||
|
|
||
| func ConstructEnvForApp(ctx context.Context, app *spinv1alpha1.SpinApp, listenPort int) []corev1.EnvVar { | ||
| envs := make([]corev1.EnvVar, len(app.Spec.Variables)) |
There was a problem hiding this comment.
do we need to make it len(app.Spec.Variabled) + 1?
There was a problem hiding this comment.
nah - it'd be technically marginally faster, but i wanna avoid making the rebase for #273 too complicated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently a "practical no-op", as we default to setting the value to the Spin Default.
It does however simplify a future, bigger, change to allow non-80 listen addresses with the container to reduce the priviliges that we give to the shim (e.g runAsNonRoot).