ca-secrets: Annotate secrets that are created by spin-operator #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eventually we will want to upgrade caBundles to new versions as certificates expire/are rotated/new ca's form. We should however only do that when we manage the resource that is created. Here we introduce a managed-by annotation that we can use to ensure that we don't replace user-managed secret bundles in the future.
endocrimes
requested review from
calebschoepp,
bacongobbler,
michelleN and
rajatjindal
as code owners
rajatjindal
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually we will want to upgrade caBundles to new versions as certificates expire/are rotated/new ca's form. We should however only do that when we manage the resource that is created.
Here we introduce a managed-by annotation that we can use to ensure that we don't replace user-managed secret bundles in the future.