Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scaffold): add support for variables #84

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

kate-goldenring
Copy link
Contributor

@kate-goldenring kate-goldenring commented Jul 29, 2024

fixes #31

Try it out

  1. Set up a SpinKube cluster
  2. Apply an example app, supplying that required foo and bar variables using the new flag
go run main.go scaffold --from http://ghcr.io/kate-goldenring/spin-foo-bar-variables:v1 --variable foo=yoo --variable bar=yee --replicas 1 | kubectl apply -f -
  1. Port forward the k8s svc and curl the endpoint to see the variable values logged

@bacongobbler
Copy link
Collaborator

Thanks @kate-goldenring! Would you mind adding a test under scaffold_test.go to make sure the indentation looks correct to you?

@kate-goldenring
Copy link
Contributor Author

@bacongobbler added

@kate-goldenring
Copy link
Contributor Author

@bacongobbler this should be ready for another review

@bacongobbler bacongobbler merged commit 7af2cef into spinkube:main Aug 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spin k8s scaffold: variables support
2 participants