add topic name metadata calling the guest handler #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: karthik2804 <[email protected]>
Co-authored-by: Brian <[email protected]>
fibonacci1729
approved these changes
Apr 15, 2024
|
Thanks much @karthik2804, will have a look tomorrow morning and merge. |
There was a problem hiding this comment.
Thanks @karthik2804, requested a small change in comment and if you have time, probably worth updating template for this change and may include async as well while at it?
Signed-off-by: karthik2804 <[email protected]>
|
updated the template and now it also has async on it. |
suneetnangia
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The topic is now added as metadata that is passed to the guest.
closes #25